Skip to content

Recognize: bump keyless sdk to 3.2.0 - #846

Merged
eugeniobet-ping merged 3 commits into
mainfrom
chore/recognize-bump-keyless-sdk-3.2.0
Sep 22, 2026
Merged

Recognize: bump keyless sdk to 3.2.0#846
eugeniobet-ping merged 3 commits into
mainfrom
chore/recognize-bump-keyless-sdk-3.2.0

Conversation

@eugeniobet-ping

@eugeniobet-ping eugeniobet-ping commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@eugeniobet-ping
chore(recognize): update Keyless SDK web components bundle to v3.2.0
73fa4c8
@eugeniobet-ping
feat(recognize): expose requestRecognitionFrame config option
60c99ba 
Forwards the new option to the kl-auth/kl-enroll elements so the
success event can include the captured recognition frame. Requires
the Keyless SDK v3.2.0 bundle from the previous commit.
@changeset-bot

changeset-bot Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a0e8eb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud

nx-cloud Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit a0e8eb7

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded <1s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded 6m 41s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-09-20 20:40:26 UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@846

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@846

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@846

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@846

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@846

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@846

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@846

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@846

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@846

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@846

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@846

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@846

commit: a0e8eb7

@github-actions

github-actions Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Deployed 6e29591 to https://ForgeRock.github.io/ping-javascript-sdk/pr-846/6e2959185a74996aab4fc40f0fc2b8205252e735 branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions

github-actions Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/device-client - 0.0 KB (-10.3 KB, -100.0%)
🔻 @forgerock/journey-client - 0.0 KB (-94.3 KB, -100.0%)
🔺 @forgerock/recognize - 5605.5 KB (+1321.1 KB, +30.8%)

📊 Minor Changes

📉 @forgerock/device-client - 10.3 KB (-0.0 KB)
📉 @forgerock/journey-client - 94.3 KB (-0.0 KB)

➖ No Changes

➖ @forgerock/sdk-types - 9.1 KB
➖ @forgerock/oidc-client - 35.9 KB
➖ @forgerock/storage - 1.5 KB
➖ @forgerock/iframe-manager - 3.2 KB
➖ @forgerock/sdk-logger - 1.6 KB
➖ @forgerock/sdk-oidc - 5.8 KB
➖ @forgerock/sdk-request-middleware - 4.6 KB
➖ @forgerock/sdk-utilities - 18.8 KB
➖ @forgerock/protect - 144.6 KB
➖ @forgerock/davinci-client - 59.7 KB

15 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

ryanbas21
ryanbas21 approved these changes Sep 16, 2026
View reviewed changes

@ryanbas21 ryanbas21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve but i'd ask @dariosechi-ping to approve since this is yours/his domain.

@dariosechi-ping

dariosechi-ping commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

I will approve but i'd ask @dariosechi-ping to approve since this is yours/his domain.

Approved @ryanbas21

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cd62d676-dca0-49b7-bd45-c7ea4fb24a32

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Sep 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (eafe277) to head (a0e8eb7).
⚠️ Report is 158 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #846       +/-   ##
===========================================
+ Coverage   18.07%   96.29%   +78.22%     
===========================================
  Files         155        1      -154     
  Lines       24398       81    -24317     
  Branches     1203       17     -1186     
===========================================
- Hits         4410       78     -4332     
+ Misses      19988        3    -19985

see 155 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eugeniobet-ping
eugeniobet-ping merged commit cd664c5 into main Sep 22, 2026
10 checks passed
@eugeniobet-ping
eugeniobet-ping deleted the chore/recognize-bump-keyless-sdk-3.2.0 branch September 22, 2026 07:44
@ryanbas21 ryanbas21 mentioned this pull request Sep 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanbas21 ryanbas21 ryanbas21 approved these changes
@dariosechi-ping dariosechi-ping dariosechi-ping approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eugeniobet-ping @dariosechi-ping @codecov-commenter @ryanbas21